Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update globals + update configs #20

Merged
merged 1 commit into from
Oct 17, 2022
Merged

feat: update globals + update configs #20

merged 1 commit into from
Oct 17, 2022

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Oct 16, 2022

Re-submission of mysticatea#38


BREAKING CHANGE: +browser, es5, es2015, es2016, es2017, es2018, es2019, es2020, es2021 & es2022 configs will now report more globals as readonly

@MichaelDeBoey MichaelDeBoey requested a review from a team October 16, 2022 17:58
@MichaelDeBoey MichaelDeBoey self-assigned this Oct 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2022

Codecov Report

Base: 97.17% // Head: 97.17% // No change to project coverage 👍

Coverage data is based on head (c5cffea) compared to base (0f90860).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha      #20   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files          39       39           
  Lines         390      390           
=======================================
  Hits          379      379           
  Misses         11       11           
Impacted Files Coverage Δ
lib/configs/_browser-globals.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MichaelDeBoey
Copy link
Member Author

@eslint-community/eslint-tsc @eslint-community/core-team @eslint-community/mysticatea-eslint-plugin Since this plugin is adhering the same semantic versioning policy as ESLint, adding new rules to a plugin would be a breaking change, so this PR would need to be released in a major release I guess?

@MichaelDeBoey MichaelDeBoey requested review from a team October 16, 2022 18:53
@MichaelDeBoey MichaelDeBoey marked this pull request as draft October 16, 2022 18:54
@MichaelDeBoey
Copy link
Member Author

@ota-meshi What do you think we should do regarding breaking changes/releases?

@ota-meshi
Copy link
Member

If we follow the policy, I think we need a major version release.

@MichaelDeBoey MichaelDeBoey changed the base branch from main to alpha October 16, 2022 23:15
@MichaelDeBoey MichaelDeBoey marked this pull request as ready for review October 16, 2022 23:42
@MichaelDeBoey MichaelDeBoey changed the title feat: update globals + update configs feat: update globals in +browser & es* configs Oct 16, 2022
@MichaelDeBoey MichaelDeBoey changed the base branch from alpha to main October 16, 2022 23:48
BREAKING CHANGE: `+browser`, `es5`, `es2015`, `es2016`, `es2017`, `es2018`, `es2019`, `es2020`, `es2021` & `es2022` configs will now report more globals as `readonly`
@MichaelDeBoey MichaelDeBoey changed the base branch from main to alpha October 17, 2022 00:06
@MichaelDeBoey MichaelDeBoey changed the title feat: update globals in +browser & es* configs feat: update globals + update configs Oct 17, 2022
@MichaelDeBoey MichaelDeBoey merged commit aeff618 into alpha Oct 17, 2022
@MichaelDeBoey MichaelDeBoey deleted the patch-6 branch October 17, 2022 17:22
@github-actions
Copy link

🎉 This PR is included in version 15.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 15.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 15.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants