Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database docs fix #517

Merged
merged 2 commits into from
Sep 25, 2015
Merged

Database docs fix #517

merged 2 commits into from
Sep 25, 2015

Conversation

ludwikbukowski
Copy link
Contributor

Description of database configuration in docs was in two seperated locations, so I made them reffering on each other.

@michalwski
Copy link
Contributor

Hint for future. Please use [skip ci] in commit message while you update doc only. There is no need to trigger travis in this case.

@michalwski
Copy link
Contributor

I canceled the travis build as it's not required for this PR.

@@ -28,6 +28,9 @@ mysql -h localhost -u user -p -e 'create database mongooseim'
mysql -h localhost -u user -p mongooseim < mysql.sql
```

You should also configure MySQL database in `[MongooseIM root]/rel/files/ejabberd.cfg` file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's enough to say "ejabberd.cfg file" instead of the path. The thing is that the ejabberd.cfg file described in Advanced-configuration.md is a template for the final config file. This, I think, should be stated in the Advanced configuration.

Same applies to next 2 changes.

michalwski added a commit that referenced this pull request Sep 25, 2015
@michalwski michalwski merged commit e276ba2 into master Sep 25, 2015
@michalwski michalwski deleted the database_docs_fix branch October 5, 2015 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants