Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth refactoring #426

Merged
merged 19 commits into from
May 5, 2015
Merged

Auth refactoring #426

merged 19 commits into from
May 5, 2015

Conversation

michalwski
Copy link
Contributor

Refactoring of auth-related modules.

One of the most significant changes is that all auth backend modules expect ejabberd:luser() and ejabberd:lserver() now in callbacks defined by ejabberd_gen_auth behaviour. In other words they don't do jlib:nodeprep(User) or jlib:nameprep(Server)

All changes taken from PR #378

michalwski added 18 commits April 13, 2015 15:08
@michalwski
improve try_register/3 API
ab3c2d3
@michalwski
adjust tests to changed try_register/3
1405614
@michalwski
extract scram_to_tuple/1
e0c01f7
@michalwski
extract scram:chceck_digest/4
856d37c
@michalwski
reuse extracted scram helpers in auth_http
29b802d
@michalwski
add stop/1 to ejabberd_gen_auth behaviour
df03f22
@michalwski
prepare username and server in ejabberd_auth
2d35668
@michalwski
do not prepare username and server in auth_odbc
a3beab0
@michalwski
do not prepare username and server in auth_internal
c633fb5
@michalwski
do not prepare username and server in auth_http
82c9d11
@michalwski
do not prepare username and server in auth_anonymous
47f41df
@michalwski
do not prepare username and server in auth_external
67aefd5
@michalwski
do not prepare username and server in auth_ldap
0643399
@michalwski
call methods defined in behaviour
3bb9aed
@michalwski
change specs in ejabberd_gen_auth behaviour
582f435
@michalwski
rename is_user_exists to does_user_exist (in backend modules)
e4ca38c
@michalwski
fix ejabberd_auth:get_password_s
7f1ac45
@michalwski
use ejabberd_tests from esl
0bd20a7
@mongoose-im
Copy link
Collaborator

travis is using test branch auth-refactoring from https://github.com/esl/ejabberd_tests/tree/auth-refactoring

@michalwski michalwski mentioned this pull request Apr 13, 2015
Merged
@michalwski michalwski mentioned this pull request Apr 13, 2015
Merged
studzien added a commit that referenced this pull request May 5, 2015
@studzien
Merge pull request #426 from esl/auth-refactoring
8d387dd 
Auth refactoring
@studzien studzien merged commit 8d387dd into master May 5, 2015
@ppikula ppikula deleted the auth-refactoring branch September 11, 2015 16:14
@michalwski michalwski mentioned this pull request Sep 17, 2015
Closed
@michalwski michalwski mentioned this pull request Oct 15, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalwski @mongoose-im @studzien