Use cqerl as cassandra client library #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenek
reviewed
Jan 11, 2017
| @@ -1,4 +1,5 @@ | |||
| language: erlang | |||
| dist: trusty | |||
There was a problem hiding this comment.
Here's the answer: #1133 (comment) :)
michalwski
reviewed
Jan 16, 2017
| row_to_uniform_format(#{from_jid := FromJID, message := Msg, id := Id}) -> | ||
| SrcJID = unserialize_jid(FromJID), | ||
| Packet = stored_binary_to_packet(Msg), | ||
| MsgID = Id, |
There was a problem hiding this comment.
Do we need MsgID? Can we simply return Id or assign id from the input map to MsgID?
There was a problem hiding this comment.
No, it's just an artefact of refactoring. It'll be gone after next push.
rslota
force-pushed
the
feature/use-cqerl-as-cassandra-driver
branch
from
d2096a5 to
46eebec
Compare
rslota
force-pushed
the
feature/use-cqerl-as-cassandra-driver
branch
3 times, most recently
from
6fd4c5c to
1e3a3c7
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes Cassandra backend to use cqerl client library instead seestar.