Upgrade to ranch 1.3.0 #1142
Merged
Upgrade to ranch 1.3.0 #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ranch version pulled in by cowboy dependency is quite outdated and does not expose a number of useful ssl parameters (dhfile being one of the more critical ones). Issue esl#888
|
Thanks for your contribution @igors! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #888
The ranch version pulled in by cowboy is quite outdated and does not expose a number of useful ssl parameters (dh/dhfile being one of the more critical ones). As of 1.3.0 ranch blacklists ssl_options it doesn't like (rather than whitelisting).
I've ran some tests with the upgraded ranch and everything seems to be working fine.
Proposed changes include: