allow filtering moduels return modified packet in ejabberd_router:rou… #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadgetci
reviewed
Nov 11, 2016
| ?DEBUG("filter passed", []), | ||
| case catch(M:route(OrigFrom, OrigTo, OrigPacket)) of | ||
| case catch(M:route(OrigFrom, OrigTo, OrigPacketFiltered)) of | ||
| {'EXIT', Reason} -> | ||
| ?ERROR_MSG("error when routing from=~ts to=~ts in module=~p, reason=~p, packet=~ts, stack_trace=~p", |
There was a problem hiding this comment.
According to Elvis:
Line 462 is too long: ?ERROR_MSG("error when routing from=~ts to=~ts in module=~p, reason=~p, packet=~ts, stack_trace=~p",.
gadgetci
reviewed
Nov 11, 2016
| ?DEBUG("filter passed", []), | ||
| case catch(M:route(OrigFrom, OrigTo, OrigPacket)) of | ||
| case catch(M:route(OrigFrom, OrigTo, OrigPacketFiltered)) of |
There was a problem hiding this comment.
According to Elvis:
Remove the dynamic function call on line 460. Only modules that define callbacks should make dynamic calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1075
Proposed changes include:
ejabberd_router:route/4function so that it allows filtering modules change the packet and route it further