-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for numpy=2. #390
Updates for numpy=2. #390
Conversation
Following the instructions in https://numpy.org/devdocs/numpy_2_0_migration_guide.html#adapting-to-changes-in-the-copy-keyword I used scipy/scipy#20172 as a template for setting copy=False or copy=None for numpy 1.x and numpy 2.x.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to somehow get numpy2 into the CI to test the builds. Maybe we wait to merge until numpy2 is official on conda-forge.
what does |
I'll restore the |
Trying to add py312 and numpy2 to the build matrix. Let's see what happens! |
OK, I guess their release notes are out of date |
This isn't working:
|
It's a dumb rc thing ... |
Yeah copy=None is wrong here. Here are the docs: https://numpy.org/devdocs/release/2.0.0-notes.html#new-copy-keyword-meaning-for-array-and-asarray-constructors |
link is busted
|
We specify copies or no copies on purpose so properly pass by reference in places iirc. |
So the old numpy1x behavior was |
Ahhhhhhh yes that's right. doc string in 1.26:
|
I wonder if all our pushes made the system mad and now won't allocate any nodes for the macos builds ... thoughts? |
We probably had too many jobs in the queue and just had to wait for the old ones. We should be able to add bit to the GHA to cancel previous jobs. |
All tests have passed and I think this is ready. |
No description provided.