feat: build wheels (#416)

* feat: build wheels * fix: no more mambaforge * fix: always build wheels for testing * fix: only publish for release events * fix: add bzip2 for linux * fix: typo in github context name * fix: need single quotes for gha * fix: need to have bzip2 around now I guess? * fix: use bzip2 from conda * prod: update setup-miniconda * fix: use yum instead for bzip2 * prod: update gha versions and syntax * fix: ubuntu uses apt 🤦 * fix: try this name * fix: use correct bzip2 dev package for wheels just in case * Add concurrency group to wheel workflow * feat: add dependabot * fix: set python version in wheel build * fix: spacing * fix: add support for workflow dispatch * test: add tests for wheels * test: add tests for other wheels * fix: run tests for alpine * fix: test w/e version of python we have for musl * debug: what is this * fix: use a venv * fix: buggy activation * Update wheel.yml * feat: skip existing things * feat: add token secret for publishing
esheldon · Jan 24, 2025 · 7c54de2 · 7c54de2
1 parent c2d5b5c
commit 7c54de2
Show file tree

Hide file tree

Showing 3 changed files with 240 additions and 9 deletions.
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -0,0 +1,10 @@
+version: 2
+updates:
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "monthly"
+    groups:
+      github-actions:
+        patterns:
+          - '*'
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -9,6 +9,10 @@ on:
 env:
   PY_COLORS: "1"
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
 jobs:
   tests:
     name: tests
@@ -22,21 +26,15 @@ jobs:
     runs-on: ${{ matrix.os }}
 
     steps:
-      - name: cancel previous runs
-        uses: styfle/cancel-workflow-action@0.6.0
-        with:
-          access_token: ${{ github.token }}
-
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
 
-      - uses: conda-incubator/setup-miniconda@v2
+      - uses: conda-incubator/setup-miniconda@d2e6a045a86077fb6cad6f5adf368e9076ddaa8d  # v3.1.0
         with:
           python-version: ${{ matrix.pyver }}
-          channels: conda-forge/label/numpy_rc,conda-forge,defaults
+          channels: conda-forge
           channel-priority: strict
           show-channel-urls: true
           miniforge-version: latest
-          miniforge-variant: Mambaforge
 
       - name: install conda deps
         shell: bash -l {0}
@@ -47,6 +45,12 @@ jobs:
             mamba install importlib_resources
           fi
 
+      - name: install bzip2 on linux
+        shell: bash -l {0}
+        if: matrix.os == 'ubuntu-latest'
+        run: |
+          sudo apt-get install libbz2-dev
+
       - name: build external cfitsio
         shell: bash -l {0}
         run: |

diff --git a/.github/workflows/wheel.yml b/.github/workflows/wheel.yml
@@ -0,0 +1,217 @@
+# this is based on the wheel workflow in GalSim, but adapted to our needs
+name: build wheels and sdist
+
+on:
+  workflow_dispatch:
+    inputs:
+      ref:
+        description: 'The git ref to build wheels for. This will trigger a pypi upload.'
+        default: ''
+        required: false
+        type: string
+      cibw_skip:
+        description: 'Python versions to skip when building wheels.'
+        default: 'cp36* cp37* pp* cp38*'
+        required: false
+        type: string
+  pull_request: null
+  release:
+    types:
+      - published
+
+concurrency:
+  group: pypi
+  cancel-in-progress: false
+
+env:
+  PYVER: '3.11'
+  CIBW_SKIP_VAL: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.cibw_skip || 'cp36* cp37* pp* cp38*' }}
+
+jobs:
+  linux-manylinux:
+    name: linux-manylinux
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          ref: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.ref || '' }}
+
+      - uses: actions/setup-python@v5
+        with:
+          python-version: '${{ env.PYVER }}'
+
+      - name: build wheels
+        uses: pypa/cibuildwheel@v2.21.1
+        env:
+          CIBW_BUILD: "*manylinux*"
+          CIBW_ARCHS: auto64
+          CIBW_SKIP: ${{ env.CIBW_SKIP_VAL }}
+          # I think yum might always work here.  But leave all options available.
+          CIBW_BEFORE_ALL: yum install -y bzip2-devel || apt-get install libbz2-dev || apk add --upgrade bzip2-dev
+
+      - name: test wheel for python ${{ env.PYVER }}
+        run: |
+          pystr='${{ env.PYVER }}'
+          pystr=${pystr//./}
+          python -m pip install pip
+          pip install numpy pytest
+          pip install ./wheelhouse/*cp${pystr}*.whl
+          pytest --pyargs fitsio
+
+      - uses: actions/upload-artifact@v4
+        with:
+          name: whl-linux
+          path: ./wheelhouse/*.whl
+
+  linux-musl:
+    name: linux-musl
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: actions/setup-python@v5
+        with:
+          python-version: '${{ env.PYVER }}'
+
+      - name: build wheels
+        uses: pypa/cibuildwheel@v2.21.1
+        env:
+          CIBW_BUILD: "*musllinux*"
+          CIBW_ARCHS: auto64
+          CIBW_SKIP: ${{ env.CIBW_SKIP_VAL }}
+          # I think musl always uses apk, but keep all options available.
+          CIBW_BEFORE_ALL: yum install -y bzip2-devel || apt-get install libbz2-dev || apk add --upgrade bzip2-dev
+
+      - uses: jirutka/setup-alpine@v1
+        with:
+          packages: "bzip2-dev python3 py3-pip py3-numpy"
+
+      - name: test wheel for python
+        shell: alpine.sh {0}
+        run: |
+          python --version
+          pystr=$(python --version | cut -d' ' -f 2 | cut -d'.' -f 1)$(python --version | cut -d' ' -f 2 | cut -d'.' -f 2)
+          mkdir test-venv
+          python3 -m venv test-venv
+          . test-venv/bin/activate
+          pip install numpy pytest
+          pip install ./wheelhouse/*cp${pystr}*musl*.whl
+          pytest --pyargs fitsio
+          deactivate
+
+      - uses: actions/upload-artifact@v4
+        with:
+          name: whl-musl
+          path: ./wheelhouse/*.whl
+
+  osx-intel:
+    name: osx-intel
+    runs-on: macos-13
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: actions/setup-python@v5
+        with:
+          python-version: '${{ env.PYVER }}'
+
+      - name: build wheels
+        uses: pypa/cibuildwheel@v2.21.1
+        env:
+          CIBW_BUILD: "*macosx*"
+          CIBW_ARCHS: auto64
+          CIBW_SKIP: ${{ env.CIBW_SKIP_VAL }}
+          # CIBW_BEFORE_ALL: brew install fftw || true
+          CIBW_ENVIRONMENT: >-
+            MACOSX_DEPLOYMENT_TARGET=13.0
+
+      - name: test wheel for python ${{ env.PYVER }}
+        run: |
+          pystr='${{ env.PYVER }}'
+          pystr=${pystr//./}
+          python -m pip install pip
+          pip install numpy pytest
+          pip install ./wheelhouse/*cp${pystr}*.whl
+          pytest --pyargs fitsio
+
+      - uses: actions/upload-artifact@v4
+        with:
+          name: whl-macos
+          path: ./wheelhouse/*.whl
+
+  osx-arm:
+    name: osx-arm
+    runs-on: macos-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: actions/setup-python@v5
+        with:
+          python-version: '${{ env.PYVER }}'
+
+      - name: build wheels
+        uses: pypa/cibuildwheel@v2.21.1
+        env:
+          CIBW_BUILD: "*macosx*"
+          CIBW_ARCHS: arm64
+          CIBW_SKIP: ${{ env.CIBW_SKIP_VAL }}
+          # CIBW_BEFORE_ALL: brew install llvm libomp fftw eigen
+          CIBW_ENVIRONMENT: >-
+            MACOSX_DEPLOYMENT_TARGET=14.7
+
+      - name: test wheel for python ${{ env.PYVER }}
+        run: |
+          pystr='${{ env.PYVER }}'
+          pystr=${pystr//./}
+          python -m pip install pip
+          pip install numpy pytest
+          pip install ./wheelhouse/*cp${pystr}*.whl
+          pytest --pyargs fitsio
+
+      - uses: actions/upload-artifact@v4
+        with:
+          name: whl-arm
+          path: ./wheelhouse/*.whl
+
+  sdist:
+    name: sdist
+    needs: [linux-manylinux, linux-musl, osx-intel, osx-arm]
+    # Just need to build sdist on a single machine
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: actions/setup-python@v5
+
+      - name: Install dependencies
+        run: |
+          python -m pip install -U pip
+          pip install -U numpy setuptools
+
+      - name: download wheels
+        uses: actions/download-artifact@v4
+        with:
+          path: ./wheels
+          pattern: whl-*
+          merge-multiple: true
+
+      - name: build sdist
+        run: |
+          python setup.py sdist
+          ls -l dist
+          tar tvfz dist/*.tar.gz
+
+      - name: copy wheels to dist
+        run: |
+          echo ls -l wheels
+          ls -l wheels
+          cp wheels/*.whl dist
+          echo ls -l dist
+          ls -l dist
+
+      - name: publish to pypi
+        uses: pypa/gh-action-pypi-publish@release/v1
+        if: github.event_name == 'release' || github.event.action == 'workflow_dispatch'
+        with:
+          verbose: true
+          skip-existing: true
+          password: ${{ secrets.PYPI_API_TOKEN }}