Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoftDelete withTrashed and onlyTrashed throw error for Laravel >= 5.2.36 #30

Closed
EngNet opened this issue Jun 7, 2016 · 1 comment
Closed

Comments

@EngNet
Copy link

EngNet commented Jun 7, 2016

Since upgrading to Laravel 5.2.36 I get the following error.

Class App\User contains 2 abstract methods and must therefore be declared abstract or implement the remaining methods
 (Esensi\Model\Contracts\SoftDeletingModelInterface::withTrashed, 
Esensi\Model\Contracts\SoftDeletingModelInterface::onlyTrashed)

The change log points to this.
laravel/framework#13396

I think both withTrashed() and onlyTrashed() were move into macros and are not standalone methods anymore.

If I comment out the interface methods for both withTrashed() and onlyTrashed() everything still seems to work.

@EngNet EngNet changed the title SoftDelete withTrashed onlyTrashed throw error for Laravel >= 5.2.36 SoftDelete withTrashed and onlyTrashed throw error for Laravel >= 5.2.36 Jun 7, 2016
@dalabarge dalabarge mentioned this issue Jun 8, 2016
@dalabarge
Copy link
Contributor

We only officially support Laravel LTS (5.1) with our packages but it is good to know that this incompatibility with future Laravel 5.2+ installs exists. We went ahead and opened a separate PR and will update there with an all around better fix for both 5.1 and 5.2+. Thanks.

dalabarge pushed a commit that referenced this issue Jun 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants