Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and Updates #70

Merged
merged 19 commits into from
Feb 9, 2024
Merged

Cleanup and Updates #70

merged 19 commits into from
Feb 9, 2024

Conversation

eseglem
Copy link
Owner

@eseglem eseglem commented Feb 1, 2024

  • Update Lark grammar to better match spec
    • Add \' to escaped quote
    • Match up Alpha, Whitespace, Identifier
    • Rename operators to function
    • Add function to boolean_primary, and increase keyword priority to avoid issues
    • Add geometry_collection to geometry_instance now that geojson pydantic supports it
  • Update Pydantic Model to latest spec
    • Rename operators to function, and switch to Literal from Enum
    • Update casei and accenti
  • Update Transformer to work with the above updates
  • Split utils to separate file and add / update tests
  • Add tests for changes
  • Update tests to use pathlib and updates hypothesis / hypofuzz
  • Make JSON filters more readable
  • Update Comments and Readme
  • Update Requirements

@bitner I think this addresses everything I really wanted to get done. If it all makes sense, I can do an actual release of it.

@bitner
Copy link
Contributor

bitner commented Feb 7, 2024

@eseglem this looks awesome! thanks for all your work on this. I did notice one thing that I made a PR to the develop branch, the alternate syntax for MULTIPOINT that does not use internal parens was not supported.

Adds support for alternate syntax for MULTIPOINT WKT without internal parentheses around coordinates.
@eseglem eseglem merged commit 8bea64d into main Feb 9, 2024
11 checks passed
@eseglem
Copy link
Owner Author

eseglem commented Feb 9, 2024

@bitner looks like I wrote the GH action correctly, and published this out as v0.2.0 now. Might have a few more tweaks I play with, for performance, but at least have a version to pin with now.

@bitner
Copy link
Contributor

bitner commented Feb 9, 2024

Awesome! Thanks @eseglem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants