Downgrade to SBT 1.2.8

[nrinaudo]

This is necessary to be compatible with a few important SBT plugins, such as sbt-scalafmt.

Note that, in order for this to work, I had to:

• drop the sbt-vspp dependency: there is no 1.2.8 compatible version. This will need to be re-enabled as soon as possible.
• downgrade the release plugins significantly. I couldn't test these and have no idea whether that broke the release process.

Other than that, all tests pass.

[nrinaudo]

Not supported in 1.2.8.

[nrinaudo]

If there was an SBT 1.2.8-compatible version, I wouldn't be doing this in the first place :)

You'll need to publish an 1.2.8-compatible version and re-enable that dependency.

[ckipp01]

@nrinaudo is sbt-scalafmt the only plugin you hit on that had issues with this?

[nrinaudo]

Oh no. Every single SBT plugin has this issue. It's mildly dreadful.

[nrinaudo]

Hang on, which issue are we talking about here?

• SBT plugins being impossible to use because they use non-standard naming conventions? Then yes, every single plugin.
• issues with some plugins being "stuck" on 1.2.8 for compatibility reason? sbt-scalafmt is the only one we've encountered that I know of

[ckipp01]

issues with some plugins being "stuck" on 1.2.8 for compatibility reason? sbt-scalafmt is the only one we've encountered that I know of

Yup, this is what I was referring to. I'm trying to figure out if we need to care about compat or can just bump to > 1.3.0 to make life easier for everyone.

[bjaglin]

I'm trying to figure out if we need to care about compat or can just bump to > 1.3.0 to make life easier for everyone.

You can use a recent version of sbt to build sbt-scalafmt, but compile it against an old sbt version for maximum compatibility. From sbt/sbt#5049:

pluginCrossBuild / sbtVersion := "1.2.8"

[ScalaWilliam]

@ckipp01 @nrinaudo yes sbt-scalafmt is the only one so far.

@bjaglin that's a very cool trick, did not know, thanks for sharing!

I don't recall the exact issue, but given the recent CVE everyone should get onto 1.8.x. The fix might've been easy but I rather not scare plugin maintainers with having to make more than 1 change, and prefer compatibility with older versions where possible. (e.g. potential questions like "why do we need to upgrade to 1.7.x? does this mean my plugin will not work for those on 1.6.x?")