-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded to Ember 4.12 #144
base: master
Are you sure you want to change the base?
Upgraded to Ember 4.12 #144
Conversation
WalkthroughThe update streamlines the codebase by removing an external dependency for UUID generation in favor of a native JavaScript function, enhances a template to support block content, and refines documentation and configuration. The changes modernize the code, improve maintainability, and embrace newer language features and best practices. Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 3
Files ignored due to filter (3)
- package.json
- tests/dummy/config/optional-features.json
- yarn.lock
Files selected for processing (5)
- addon-test-support/google-autocomplete-session-token.js (1 hunks)
- addon/components/place-autocomplete-field.hbs (1 hunks)
- addon/components/place-autocomplete-field.js (13 hunks)
- addon/services/google-place-autocomplete/manager.js (1 hunks)
- tests/dummy/app/styles/tailwind.config.js (1 hunks)
Files skipped from review due to trivial changes (3)
- addon/components/place-autocomplete-field.hbs
- addon/components/place-autocomplete-field.js
- addon/services/google-place-autocomplete/manager.js
Additional comments (Suppressed): 1
tests/dummy/app/styles/tailwind.config.js (1)
- 1-13: The
purge
andvariants
properties have been removed and replaced with thecontent
property. This change is in line with Tailwind CSS v2.0, where thepurge
option has been renamed tocontent
. Ensure that this change doesn't affect the styles in your application and that all the necessary files are included in thecontent
array for purging unused styles.- purge: [], + content: [ + 'tests/dummy/app/**/*.hbs' + ],Also, the removal of the
variants
property should be verified to ensure that no custom variants are being used in the application. If there are custom variants, they should be added back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- addon/components/place-autocomplete-field.hbs (1 hunks)
Additional comments: 1
addon/components/place-autocomplete-field.hbs (1)
- 1-14: The template has been updated to support block usage, which is a common pattern in modern Ember applications to provide more flexibility to the users of the component. The use of
has-block
to conditionally yield content is correct and aligns with Ember's templating best practices. The event handlers forblur
andinput
are also correctly attached using theon
modifier. However, ensure that theonBlur
method and themut
helper are properly defined and available in the component's JavaScript file.
@esbanarango Could you please review these changes? |
also refactored the component logic to the class structure und removed ember-uuid as dependency
Summary by CodeRabbit
New Features
Refactor
ember-uuid
library with nativecrypto.randomUUID()
for session token generation.Documentation
Style