Compiling fix for Vulnerable Regular Expression into updated list #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@esamattis @stoeffel could you please merge this to fix the ReDos vulnerability? |
|
@esamattis Is it possible for this to get merged? This is causing grunt to have an indirect vulnerability. See https://snyk.io/test/npm/grunt/1.4.0. |
|
@stoeffel can you help to merge this? |
|
3.3.6 is out with this. |
|
@esamattis It looks like Snyk is reporting that this vulnerability still exists in 3.3.6: https://snyk.io/vuln/npm:underscore.string |
|
Hmph, wonder what's missing 🤔 |
|
looks like Synk did update the latest update and it shows 3.3.6 does not have any vulnerabilities. Thanks Esa! |
|
Thanks for confirming that @carneam. Looks like grunt 1.4.0 was also updated to have 0 vulnerabilities. See: https://snyk.io/vuln/npm:grunt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @magesh0819 mentioned in his comment on #510 this fixes the issue with the ReDoS vulnerable regex by rebuilding the dist files.
This package should be redeployed to npm after merge.