Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a navigation indicator for table rows #575

Merged
merged 2 commits into from
May 1, 2024
Merged

add a navigation indicator for table rows #575

merged 2 commits into from
May 1, 2024

Conversation

erwindon
Copy link
Owner

@erwindon erwindon commented Apr 30, 2024

Is your feature request related to a problem? Please describe.
clicking on table row has various effects: it may navigate to a details page or it may show the cmd-popup.
for menu items it is less obvious since the description already gives a clue and the "..." shows that a popup will be used.
with the introduction of #574 that becomes less obvious

Describe the solution you'd like
add a i-icon to each table to show what will happen when you click on a row of that table.

Additional context
see #574

@erwindon erwindon self-assigned this Apr 29, 2024
@erwindon erwindon marked this pull request as draft April 30, 2024 18:30
@erwindon
Copy link
Owner Author

add a i-icon to each table that (on-hover) shows what will happen when you click on a row of that table

this function is added.
@rcmoutinho FYI

@erwindon erwindon force-pushed the visnav branch 2 times, most recently from 76d65cc to ea05aa0 Compare April 30, 2024 23:59
Copy link

sonarqubecloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@erwindon
Copy link
Owner Author

erwindon commented May 1, 2024

@rcmoutinho
have you tried it?

everyone:
any hints on how to show this for the items op a popup-menu are welcome!

@rcmoutinho
Copy link

So far, it works fine for me. I made just one comment so you can double-check on your side.

@erwindon erwindon marked this pull request as ready for review May 1, 2024 18:00
@erwindon erwindon changed the title add a navigation indicator for table rows and/or menu items add a navigation indicator for table rows May 1, 2024
@erwindon
Copy link
Owner Author

erwindon commented May 1, 2024

split this in 2 parts, one for table-rows (this one) and one for menu items (#579)

@erwindon erwindon merged commit b6517b6 into master May 1, 2024
4 checks passed
@erwindon erwindon deleted the visnav branch May 1, 2024 18:17
@erwindon
Copy link
Owner Author

erwindon commented May 3, 2024

I changed the style of the hint from a (?) icon to the style that is also used for panel-related help (but a bit smaller)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants