Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "saltgui_max_show_highstates" and "saltgui_max_highstate_states" in config options #570

Merged

Conversation

AntonOvseenko
Copy link
Contributor

With a large number of salt minions, it is not enough to display only the last 10 highstates. I suggest leaving the default value 10 but adding the ability to change it through the config. I would also like to be able to customize the number of states for detailed display (default is 20)

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@erwindon
Copy link
Owner

erwindon commented Apr 15, 2024

With a large number of salt minions, it is not enough to display only the last 10 highstates.

That should be unrelated... Unless of course you are running the highstate jobs individually or in small groups.

Anyway, you provide enough reason to make it a config-variable.
I'll look through the details but the overall impression is that this PR is ok.

@erwindon
Copy link
Owner

could not find a single thing to complain about :-)

@erwindon erwindon merged commit 63a2c01 into erwindon:master Apr 15, 2024
4 checks passed
@erwindon
Copy link
Owner

THX!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants