Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for parameter 'state_compress_ids' #478

Merged
merged 3 commits into from
Nov 7, 2022
Merged

Conversation

erwindon
Copy link
Owner

@erwindon erwindon commented Nov 2, 2022

Is your feature request related to a problem? Please describe.
Saltstack recently introduced parameter state_compress_ids.
This will change the output for some output models

Describe the solution you'd like
Let SaltGUI adjust the output in the same way.

See also https://docs.saltproject.io/en/latest/ref/output/all/salt.output.highstate.html

sample output (state_compress_ids=false):

salt-minion-1:
  Name: apache-2 xyz - Function: cmd.run - Result: Changed Started: - 01:30:40.995510 Duration: 6.268 ms
  Name: apache-2 xyz - Function: cmd.run - Result: Failed Started: - 01:30:41.019488 Duration: 7.277 ms
  Name: apache-2 xyz - Function: cmd.run - Result: Changed Started: - 01:30:41.045495 Duration: 6.882 ms
  Name: apache-2 xyz - Function: cmd.run - Result: Failed Started: - 01:30:41.069218 Duration: 7.714 ms

sample output (state_compress_ids=true):

salt-minion-1:
  Name: apache-2 xyz (2) - Function: cmd.run - Result: Changed Started: - 01:35:59.463025 Duration: 26.798 ms
  Name: apache-2 xyz (2) - Function: cmd.run - Result: Failed Started: - 01:35:59.509360 Duration: 24.024 ms

note:

  • count added to name part
  • starttime is lowest of all starttimes
  • duration is sum of all durations
  • original saltstack fails when there is at least one error state; but we can skip those

@erwindon erwindon self-assigned this Sep 11, 2022
@erwindon erwindon changed the title addm suppor for parameter 'state_compress_ids' add support for parameter 'state_compress_ids' Sep 13, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@erwindon
Copy link
Owner Author

erwindon commented Nov 7, 2022

original:
afbeelding

compressed:
afbeelding

@erwindon erwindon merged commit db85f1e into master Nov 7, 2022
@erwindon erwindon deleted the state_compress_ids branch November 7, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant