Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show all IP numbers of a minion #472

Merged
merged 0 commits into from
Aug 16, 2022
Merged

show all IP numbers of a minion #472

merged 0 commits into from
Aug 16, 2022

Conversation

erwindon
Copy link
Owner

@erwindon erwindon commented Aug 14, 2022

Is your feature request related to a problem? Please describe.
Currently a single IP number is shown.
Also, the the selection process for this is slightly broken.

Describe the solution you'd like
Add all IP numbers in the tooltip when CTRL is held there are multiple addresses.
Use ALT-CLICK to copy them all (CTRL-CLICK also selects the element)

Additionally, remove the logic to select the best IP number and replace with:

  • make it (for now statically) configurable which grain is used.
  • remove any IP number that is also reported by other minions.
  • rank the ip numbers according to their address-class and take the first-best one.
  • make sure that data related errors are not fatal: grain does not exist, grain is not an array of strings, the strings are not IP numbers.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@erwindon erwindon merged commit 90f2c65 into master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant