Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance visibility and layout of buttons #377

Merged
merged 2 commits into from
Aug 22, 2021
Merged

enhance visibility and layout of buttons #377

merged 2 commits into from
Aug 22, 2021

Conversation

erwindon
Copy link
Owner

@erwindon erwindon commented Aug 21, 2021

buttons have poor layout: the spacing is ad-hoc
buttons have poor visibility: the button image is usually a visual character so that the active area is unclear

This PR creates a grey background colour for each button.
This immediately makes the layout problem more visible, so the layout instructions are re-worked.

@erwindon erwindon force-pushed the smallbuttons branch 3 times, most recently from dd7b17e to 6e599fe Compare August 21, 2021 00:53
@erwindon
Copy link
Owner Author

@dawidmalina
In late 2018 and early 2019, you provided an updated design for SaltGUI.
This design has been still remains, but there were a few minor issues with the (menu) buttons.

Because, over time, a few more buttons were added to several screens:

  • button for panel-level menu (until then: only a menu item existed per table row)
  • button to start search in tables
  • button to pause/continue automatic screen updates
  • and a few more

And the buttons were not always recognizable since they were typically constructed using a single graphical character. So it was not always clear that the character even represented a button or a popup-menu. Also the extra margins around these characters were not visible. This resulted in an odd look for buttons that were near the edge of a block.

So a bit improvement was needed...

This PR cleans up the graphical design wrt to regular buttons and popup-menu buttons.

Can you please have a look at the graphical side of the result?
If/when you feel like it of course, as you may have moved away from SaltGUI or even away from SaltStack.

thx!

@erwindon erwindon self-assigned this Aug 21, 2021
@erwindon erwindon marked this pull request as draft August 21, 2021 00:57
@erwindon erwindon force-pushed the smallbuttons branch 3 times, most recently from 0e9a281 to 6b2b21b Compare August 21, 2021 11:28
@dawidmalina
Copy link
Contributor

Hi @erwindon I can take a look on this but not within next 2 weeks. Never the less I must agreed with you - my involment with project, saltstack is close to zero right now as I am focusing now on different topics. I know that SaltGUI is in good hands :)

@erwindon
Copy link
Owner Author

@dawidmalina thx for the quick response and the compliment! I'll now not let this PR depend on this, but feel free to still take a look at it at any time and send any remarks this way.

@erwindon erwindon marked this pull request as ready for review August 22, 2021 11:55
@erwindon erwindon merged commit 363764b into master Aug 22, 2021
@erwindon erwindon deleted the smallbuttons branch August 22, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants