Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump slackclient to 1.2.0 with support to reconnect #1184

Closed
wants to merge 2 commits into from
Closed

Bump slackclient to 1.2.0 with support to reconnect #1184

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
980123d
Bump slackclient to 1.2.0 with support to reconnect
Apr 9, 2018
c921902
Remove unnecessary changes
Apr 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
v5.2.0 (2018-04-05)
-------------------

fixes:

- Message: Allow partial message size
- Slack: include the option to set Proxy when connecting using SlackClient
- Slack: fix member joined channel event handler

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this was meant to be committed. If you could rebase this out so only the changes to slack.py and setup.py remain I'll be happy to merge. 😄

v5.1.3 (2017-10-15)
-------------------

Expand Down
2 changes: 1 addition & 1 deletion errbot/backends/slack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ def serve_once(self):
self.bot_identifier = SlackPerson(self.sc, self.auth["user_id"])

log.info("Connecting to Slack real-time-messaging API")
if self.sc.rtm_connect():
if self.sc.rtm_connect(auto_reconnect=True):
log.info("Connected")
# Block on reads instead of using the busy loop suggested in slackclient docs
# https://github.com/slackapi/python-slackclient/issues/46#issuecomment-165674808
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def read(fname, encoding='ascii'):
'graphic': ['PySide', ],
'hipchat': ['hypchat', 'sleekxmpp', 'pyasn1', 'pyasn1-modules'],
'IRC': ['irc', ],
'slack': ['slackclient>=1.0.5', ],
'slack': ['slackclient>=1.2.0', ],
'telegram': ['python-telegram-bot', ],
'XMPP': ['sleekxmpp', 'pyasn1', 'pyasn1-modules'],
},
Expand Down