golangci lint (#822)

* chore: add dupword to golangci-lint

It checks for duplicate words in the source code.

Added in golangci-lint v1.50.0

Also, fix the reported issues

* chore: add usestdlibvars to golangci-lint

A linter that detect the possibility to use variables/constants from the Go standard library.

Added in golangci-lint v1.48.0

Also, fix the reported issue

* chore: add mirror to golangci-lint

A linter that reports wrong mirror patterns of bytes/strings usage.

Added in golangci-lint v1.53.0

Also, fix the reported issue

* chore: add thelper to golangci-lint

This linter checks tests helpers which is not start with t.Helper() method.

Added in golangci-lint v1.34.0

Also, fix the reported issues

.golangci.yml

@@ -78,6 +78,7 @@ linters:
     - bodyclose
     - contextcheck
     - dupl
+    - dupword
     - durationcheck
     - errname
     - errorlint
@@ -91,6 +92,7 @@ linters:
     - goprintffuncname
     - gosec
     - makezero
+    - mirror
     - nakedret
     - nilerr
     - nilnil
@@ -105,8 +107,10 @@ linters:
     - sqlclosecheck
     - stylecheck
     - tenv
+    - thelper
     - tparallel
     - unconvert
     - unparam
+    - usestdlibvars
     - wastedassign
     - whitespace

cmd/vale/api.go

@@ -61,7 +61,7 @@ func fetch(src, dst string) error {
 
 	if err != nil {
 		return err
-	} else if resp.StatusCode != 200 {
+	} else if resp.StatusCode != http.StatusOK {
 		return fmt.Errorf("could not fetch '%s' (status code '%d')", src, resp.StatusCode)
 	}
 

internal/check/existence.go

@@ -69,7 +69,7 @@ func NewExistence(cfg *core.Config, generic baseCheck, path string) (Existence,
 	return rule, nil
 }
 
-// Run executes the the `existence`-based rule.
+// Run executes the `existence`-based rule.
 //
 // This is simplest of the available extension points: it looks for any matches
 // of its internal `pattern` (calculated from `NewExistence`) against the

internal/check/repetition.go

@@ -58,7 +58,7 @@ func NewRepetition(cfg *core.Config, generic baseCheck, path string) (Repetition
 	return rule, nil
 }
 
-// Run executes the the `repetition`-based rule.
+// Run executes the `repetition`-based rule.
 //
 // The rule looks for repeated matches of its regex -- such as "this this".
 func (o Repetition) Run(blk nlp.Block, _ *core.File) ([]core.Alert, error) {

internal/check/substitution.go

@@ -97,7 +97,7 @@ func NewSubstitution(cfg *core.Config, generic baseCheck, path string) (Substitu
 	return rule, nil
 }
 
-// Run executes the the `substitution`-based rule.
+// Run executes the `substitution`-based rule.
 //
 // The rule looks for one pattern and then suggests a replacement.
 func (s Substitution) Run(blk nlp.Block, _ *core.File) ([]core.Alert, error) {

internal/core/util.go

@@ -286,7 +286,7 @@ func ReplaceAllStringSubmatchFunc(re *regexp.Regexp, str string, repl func([]str
 	result := ""
 	lastIndex := 0
 
-	for _, v := range re.FindAllSubmatchIndex([]byte(str), -1) {
+	for _, v := range re.FindAllStringSubmatchIndex(str, -1) {
 		groups := []string{}
 		for i := 0; i < len(v); i += 2 {
 			if v[i] == -1 || v[i+1] == -1 {

internal/lint/lint_test.go

@@ -59,7 +59,9 @@ func initLinter() (*Linter, error) {
 	return NewLinter(cfg)
 }
 
-func benchmarkLint(path string, b *testing.B) {
+func benchmarkLint(b *testing.B, path string) {
+	b.Helper()
+
 	linter, err := initLinter()
 	if err != nil {
 		b.Fatal(err)
@@ -79,9 +81,9 @@ func benchmarkLint(path string, b *testing.B) {
 }
 
 func BenchmarkLintRST(b *testing.B) {
-	benchmarkLint("../../testdata/fixtures/benchmarks/bench.rst", b)
+	benchmarkLint(b, "../../testdata/fixtures/benchmarks/bench.rst")
 }
 
 func BenchmarkLintMD(b *testing.B) {
-	benchmarkLint("../../testdata/fixtures/benchmarks/bench.md", b)
+	benchmarkLint(b, "../../testdata/fixtures/benchmarks/bench.md")
 }