fix: handle regex-based replacements

errata-ai · Dec 25, 2024 · 0c4f880 · 0c4f880
1 parent df4a934
commit 0c4f880
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 8 deletions.
diff --git a/internal/check/manager.go b/internal/check/manager.go
@@ -272,9 +272,7 @@ func (mgr *Manager) loadVocabRules() {
 	if len(mgr.Config.AcceptedTokens) > 0 {
 		vocab := defaultRules["Terms"]
 		for _, term := range mgr.Config.AcceptedTokens {
-			if core.IsPhrase(term) {
-				vocab["swap"].(map[string]string)[strings.ToLower(term)] = term
-			}
+			vocab["swap"].(map[string]string)[strings.ToLower(term)] = term
 		}
 		if level, ok := mgr.Config.RuleToLevel["Vale.Terms"]; ok {
 			vocab["level"] = level

diff --git a/testdata/features/misc.feature b/testdata/features/misc.feature
@@ -11,6 +11,7 @@ Feature: Misc
             test.md:19:1:Vale.Terms:Use 'ABCDEF' instead of 'ABCDEf'.
             test.md:21:1:Vale.Terms:Use 'ABC-DEF' instead of 'ABC-DEf'.
             test.md:23:1:Vale.Terms:Use 'PLuG' instead of 'plug'.
+            test.md:27:17:Vale.Terms:Use '[Oo]bservability' instead of 'oBservability'.
             """
 
     Scenario: Multiple Vocabs

diff --git a/testdata/fixtures/vocab/Basic/test.md b/testdata/fixtures/vocab/Basic/test.md
@@ -22,4 +22,8 @@ ABC-DEf
 
 plug
 
-Github
+Github
+
+This is no good oBservability.
+
+This Observability and observability are okay.
diff --git a/testdata/fixtures/vocab/styles/config/vocabularies/Basic/accept.txt b/testdata/fixtures/vocab/styles/config/vocabularies/Basic/accept.txt
@@ -1,9 +1,10 @@
+(?i)GitHub
+[Oo]bservability
 [pP]y.*\b
-definately
 # This is a comment
+ABC-DEF
+ABCDEF
+definately
 Documentarians
 Log4j
-ABCDEF
-ABC-DEF
 PLuG
-(?i)GitHub
-Original file line number
+Diff line change
@@ Expand Up / @@ -22,4 +22,8 @@ ABC-DEf @@
     plug
-    Github
+    Github
+    This is no good oBservability.
+    This Observability and observability are okay.