Support parsing microseconds with a parse_exact/1 function #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aseigo This looks nice. We'll need to add some unit tests, though. Could you rebase and re-push? Note that the original project has a new maintainer and a new home: That being said, the old links to the original repo will redirect to the new home -- both in the browser and via the cli. |
|
@hachreak Sure! This PR's branch has conflicts -- if you want to take it over (preserving the history/work done so far) and get those resolved, that would be great. It also needs some unit tests around the new feature (and tests that ensure pre-existing functionality is not broken in anyway). |
|
Obsoleted by pr #31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to make this as non-invasive and backwards compatible as possible. I need the ability to parse exact dates out for later reformating ... this makes it trivial to go from string containing an iso8601 datetime with tz to a string in UTC:
1> iso8601:format(iso8601:parse_exact("2015-02-23T14:59:49.717+01:00")).
<<"2015-02-23T13:59:49.717Z">>
Am happy to make adjustment as needed.