Correct error message for binary_to_existing_atom/2 #4901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorng
added
team:VM
bjorng
force-pushed
the
bjorn/fix-error-info/GH-4900/OTP-17449
branch
from
8660d07 to
3fdabfb
Compare
The extended error information for `binary_to_existing_atom/2` was wrong
when the encoding was `utf8` or `unicode`:
1> binary_to_existing_atom(<<"oops doesnt_really_exist">>, utf8).
** exception error: bad argument
in function binary_to_existing_atom/2
called as binary_to_existing_atom(<<"oops doesnt_really_exist">>,utf8)
*** argument 1: invalid UTF8 encoding
Corrected:
1> binary_to_existing_atom(<<"oops doesnt_really_exist">>, utf8).
** exception error: bad argument
in function binary_to_existing_atom/2
called as binary_to_existing_atom(<<"oops doesnt_really_exist">>,utf8)
*** argument 1: not an already existing atom
Also fixed a similar problem for `list_to_existing_atom/1`.
Closes erlang#4900.
bjorng
force-pushed
the
bjorn/fix-error-info/GH-4900/OTP-17449
branch
from
3fdabfb to
c1942e3
Compare
|
Forgot to fix the bug for |
garazdawi
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extended error information for
binary_to_existing_atom/2was wrongwhen the encoding was
utf8orunicode:Corrected:
Also fixed a similar problem for
list_to_existing_atom/1.Closes #4900.