Commit generated configure scripts #4835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickard-green
force-pushed
the
rickard/configure/24/OTP-17398
branch
from
5836346 to
c07094a
Compare
rickard-green
force-pushed
the
rickard/configure/24/OTP-17398
branch
from
c07094a to
81b8efe
Compare
rickard-green
force-pushed
the
rickard/configure/24/OTP-17398
branch
from
81b8efe to
ebbe53e
Compare
* rickard/configure/OTP-17398: Support for committing of configure scripts
…17398 * rickard/configure/OTP-17398: Support for committing of configure scripts
rickard-green
force-pushed
the
rickard/configure/24/OTP-17398
branch
from
ebbe53e to
3cbb27b
Compare
5 tasks
v0idpwn
added a commit
to v0idpwn/otp
that referenced
this pull request
May 23, 2021
This step is not needed as of erlang#4835
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating
configurescripts with autoconf version 2.70/2.71 might cause faulty configuration of OTP.We (OTP) have always delivered OTP with already generated
configurescripts in the tar file we publish. The tar file is what we have considered the deliverable. Today a lot of people (probably the most) build from a tag in the git repository and do not build from the tar file. It is therefore probably time to consider the tag in the git repository as the deliverable and include already generatedconfigurescripts in git as well. This way old OTP releases wont be broken by new autoconf versions, and we get time to adjust the scripts in the latest release to new autoconf versions.Fixes #4821