Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add naettUserAgent option #17

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Add naettUserAgent option #17

merged 4 commits into from
Jul 31, 2023

Conversation

hrydgard
Copy link
Contributor

@hrydgard hrydgard commented Jul 21, 2023

Lets you specify the user agent per request, sometimes useful.

Tried to find the optimal way to do it on each platform.

Also, fixes a bunch of warnings on MSVC.

Testing on Mac and Linux coming up. works.

Fixes #15

@erkkah
Copy link
Owner

erkkah commented Jul 21, 2023

Awesome! Will take a look, hopefully this weekend. Tack!

@hrydgard
Copy link
Contributor Author

Hi again, any chance you could look at these PRs?

@erkkah
Copy link
Owner

erkkah commented Jul 30, 2023

Absolutely! Been afk for a while.

Copy link
Owner

@erkkah erkkah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I noticed that the tests did not pass on Linux, a simple logic error.

src/naett_core.c Outdated Show resolved Hide resolved
src/naett_linux.c Outdated Show resolved Hide resolved
src/naett_win.c Outdated Show resolved Hide resolved
@hrydgard
Copy link
Contributor Author

Rebased on main and addressed the feedback.

@erkkah erkkah merged commit c279ff6 into erkkah:main Jul 31, 2023
4 checks passed
@hrydgard hrydgard deleted the user-agent branch July 31, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

naettInit or naettOption for user agent?
2 participants