Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mariadb): correct the grate internal migration script - issue 569 #606

Merged
merged 5 commits into from
Jan 20, 2025

Conversation

hoangthanh28
Copy link
Contributor

@hoangthanh28
Copy link
Contributor Author

Hi @erikbra
Please help to review this PR and merge the fix for MariaDB. Looks like the current sql script is not fully compatible with older version of MySql.

Thanks.

@erikbra
Copy link
Owner

erikbra commented Jan 19, 2025

Thanks a lot, @hoangthanh28! It looks mostly good. Could you please look at my comment? And, while we're on the nit-picking - could you please fix the spelling of "exits" to "exists" in the new filenames? :)

e.g. : src/grate.mariadb/Bootstrapping/Sql/GrateStructure/up/00_02_fix_version_table_casing_if_exits.sql
to. : src/grate.mariadb/Bootstrapping/Sql/GrateStructure/up/00_02_fix_version_table_casing_if_exists.sql

other than that, this looks good, and I'm happy you solved the issue for actual MySql users (MySql seems to be dropping a bit behind MariaDb after Oracle bought it)

@erikbra
Copy link
Owner

erikbra commented Jan 20, 2025

The file names look good now, @hoangthanh28 - thanks! 😄

@erikbra erikbra merged commit f74001f into erikbra:main Jan 20, 2025
32 of 33 checks passed
@hoangthanh28 hoangthanh28 deleted the hotfixes/thanh/issue-569 branch January 20, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants