Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create logger after instantiating DbMigrator to make sure the new con… #520

Conversation

JaDuyve
Copy link
Contributor

@JaDuyve JaDuyve commented May 12, 2024

Create logger after instantiating DbMigrator to make sure the new configuration is used to determine if grate is running internally, yes or no. This is regarding issue #519.

…figuration is used to determine if grate is running internally, yes or no.
@erikbra
Copy link
Owner

erikbra commented May 15, 2024

Yeps, you are absolutely correct, @JaDuyve ! Well spotted 😄

@erikbra erikbra merged commit 6017954 into erikbra:main May 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants