Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task #485: Add factory IFoldersConfiguration builder 'Folders' for convenience #490

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

erikbra
Copy link
Owner

@erikbra erikbra commented Apr 1, 2024

Make it easier to configure custom folder configurations when using grate as a library.

Solves #485

@erikbra erikbra added this to the 1.6.3 milestone Apr 1, 2024
@erikbra erikbra self-assigned this Apr 1, 2024
@erikbra erikbra marked this pull request as ready for review April 1, 2024 20:28
@erikbra erikbra merged commit 4ce6271 into main Apr 1, 2024
17 checks passed
@erikbra erikbra deleted the feat/485-folderconfiguration branch April 1, 2024 20:29
@@ -128,4 +121,18 @@ public void Creates_default_builder_with_environment_name(string environmentName
grateConfiguration.Environment.Should().BeEquivalentTo(new GrateEnvironment(environmentName));
}

[Fact]
public void Creates_default_builder_with_custom_folder_configuration()
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check out this test, @JaDuyve - I think this fix will solve your request, don't you agree?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this should do the trick! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants