Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade both upload-artifact and download-artifact to v4 (they work in concert) #459

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Upgrade both upload-artifact and download-artifact to v4 (they work in concert) #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
VERSION: ${{ needs.set-version-number.outputs.nuGetVersion }}

- name: Upload published tool artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: ${{ needs.set-version-number.outputs.is-release == 'true' }}
with:
name: grate-dotnet-tool-${{ needs.set-version-number.outputs.nuGetVersion }}
Expand Down Expand Up @@ -128,7 +128,7 @@ jobs:

- name: Upload self-contained ${{ matrix.arch }}
#if: ${{ needs.set-version-number.outputs.is-release == 'true' }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: grate-${{ matrix.arch }}-self-contained-${{ needs.set-version-number.outputs.nuGetVersion }}
path: ./publish/${{ matrix.arch }}/self-contained/*
Expand Down Expand Up @@ -163,7 +163,7 @@ jobs:

- name: Upload self-contained ${{ matrix.arch }}
#if: ${{ needs.set-version-number.outputs.is-release == 'true' }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: grate-${{ matrix.arch }}-self-contained-${{ needs.set-version-number.outputs.nuGetVersion }}
path: ./publish/${{ matrix.arch }}/self-contained/*
Expand All @@ -182,7 +182,7 @@ jobs:

steps:
- uses: actions/checkout@v4
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: grate-${{ matrix.arch }}-self-contained-${{ needs.set-version-number.outputs.nuGetVersion }}
path: ${{ matrix.arch }}/
Expand All @@ -194,7 +194,7 @@ jobs:
VERSION: ${{ needs.set-version-number.outputs.nuGetVersion }}

- name: Upload MSI ${{ matrix.arch }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: grate-msi-${{ matrix.arch }}-${{ needs.set-version-number.outputs.nuGetVersion }}
path: ./installers/msi/tmp/*.msi
Expand All @@ -213,7 +213,7 @@ jobs:

steps:
- uses: actions/checkout@v4
# - uses: actions/download-artifact@v3 # download from another artifact is not a good idea, we need to build directly from source
# - uses: actions/download-artifact@v4 # download from another artifact is not a good idea, we need to build directly from source
# with:
# name: grate-linux-musl-x64-self-contained-${{ needs.set-version-number.outputs.nuGetVersion }}
# path: installers/docker/
Expand Down Expand Up @@ -261,7 +261,7 @@ jobs:

steps:
- uses: actions/checkout@v4
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: grate-${{ matrix.arch }}-self-contained-${{ needs.set-version-number.outputs.nuGetVersion }}
path: ${{ matrix.arch }}/
Expand All @@ -279,7 +279,7 @@ jobs:
VERSION: ${{ needs.set-version-number.outputs.nuGetVersion }}

- name: Upload .dpkg ${{ steps.get-arch.outputs.arch }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: grate_${{ needs.set-version-number.outputs.nuGetVersion }}-1_${{ steps.get-arch.outputs.arch}}.deb
path: ./installers/deb/grate_${{ needs.set-version-number.outputs.nuGetVersion }}-1_${{ steps.get-arch.outputs.arch }}.deb
Expand Down Expand Up @@ -352,7 +352,7 @@ jobs:
runs-on: ${{ matrix.os.name }}
steps:
- uses: actions/checkout@v4
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: grate-${{ matrix.os.arch }}-self-contained-${{ needs.set-version-number.outputs.nuGetVersion }}
path: executables/${{ matrix.os.arch }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ jobs:

- name: Upload Unit Test Results
if: always()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: "${{ matrix.category }} XML test results"
path: |
Expand All @@ -106,7 +106,7 @@ jobs:

steps:
- name: Download XML test reports
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
path: test-results

Expand Down Expand Up @@ -150,7 +150,7 @@ jobs:
/tmp/smink/smink "${XML_DIR}/*.xml" "${REPORT_DIR}/test-report.html" --title "grate unit tests"

- name: Upload HTML test report
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: HTML test report
path: |
Expand Down