Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests on the build, trimmed, self-contained command-line binaries #456

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

erikbra
Copy link
Owner

@erikbra erikbra commented Mar 1, 2024

.Net gets more and more trimming and compiling features going forward, and, if we e.g. should replace System.Commandline, which never seems to get out of beta, with another command-line parsing library, I feel much more confident doing this if we have a lot of tests on the packaged an build binaries too, in addition to the DLLs directly.

I reused the existing unit tests, being a bit creative with the .csproj files and includes. I hope it is a good idea, and that we don't have to duplicate up any new tests we should write on the migrations for both DLLs/libraries and command-line. Including the files should make the tests be available for both automagically.

  • Add test projects for all databases for compiled command-line grate executable
  • Add running of these tests to the Build and Release build pipeline
  • Extracted unit test project imports to separate .targets file

.Net gets more and more trimming and compiling features going forward, and, if we e.g. should replace System.Commandline, which
never seems to get out of beta, with another command-line parsing library, I feel much more confident doing this if we have a lot of tests
on the packaged an build binaries too, in addition to the DLLs directly.

I reused the existing unit tests, being a bit creative with the .csproj files and includes. I _hope_ it is a good idea, and that we don't have to
duplicate up any new tests we should write on the migrations for both DLLs/libraries and command-line. Including the files should make the
tests be available for both automagically.

* Add test projects for all databases for compiled command-line grate executable
* Add running of these tests to the Build and Release build pipeline
* Extracted unit test project imports to separate .targets file
@erikbra erikbra added this to the 1.6.2 milestone Mar 1, 2024
@erikbra erikbra self-assigned this Mar 1, 2024
@erikbra erikbra marked this pull request as ready for review March 1, 2024 06:12
@erikbra erikbra merged commit 72a2a8d into main Mar 1, 2024
49 checks passed
@erikbra erikbra deleted the chore/tests-for-cmdline branch March 1, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant