Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baseline creates orphan version_id in ScriptsRun #553

Closed
bhorn opened this issue Jun 27, 2024 · 1 comment · Fixed by #567
Closed

Baseline creates orphan version_id in ScriptsRun #553

bhorn opened this issue Jun 27, 2024 · 1 comment · Fixed by #567
Assignees
Labels
bug Something isn't working
Milestone

Comments

@bhorn
Copy link

bhorn commented Jun 27, 2024

When running baseline (SQL Server), while 'in progress' there is a new version in the grate.Version table, but on completion this has vanished, and the grate.ScriptsRun table is left with a set of entries with a non-existent version_id.

The version_id is then reused on the next grate run, so ScriptsRun ends up mixing Baseline and Update1 into one version_id, which is a bit confusing.

@RW-RuneAnkerroLiljegren

That aligns with what i have observed, but maybe i have not understood what the baseline actually does? I assume that I would get a version row inside my grate.Version when using --baseline, is that understood correctly and there is an issue here?

erikbra added a commit that referenced this issue Jul 24, 2024

Verified

This commit was signed with the committer’s verified signature.
rock3r Sebastiano Poggi
When running in baseline mode, no SQL is actually run, so there was not inserted any entry
into the Version table. However, this should be inserted in baseline mode, as this makes sense
business-wise, to register the baseline as a version of the database (even with no changes)

Fixes #553
@erikbra erikbra added the bug Something isn't working label Jul 24, 2024
@erikbra erikbra self-assigned this Jul 24, 2024
@erikbra erikbra added this to the 1.8.0 milestone Jul 24, 2024
erikbra added a commit that referenced this issue Jul 24, 2024

Verified

This commit was signed with the committer’s verified signature.
rock3r Sebastiano Poggi
When running in baseline mode, no SQL is actually run, so there was not inserted any entry
into the Version table. However, this should be inserted in baseline mode, as this makes sense
business-wise, to register the baseline as a version of the database (even with no changes)

Fixes #553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants