Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various updates to SqlServerSyntax are needed #243

Closed
RachelAmbler opened this issue Sep 12, 2022 · 1 comment
Closed

Various updates to SqlServerSyntax are needed #243

RachelAmbler opened this issue Sep 12, 2022 · 1 comment

Comments

@RachelAmbler
Copy link
Contributor

Multiple issues: Things like next should be NVarChar(Max), Double quotes are used where [] should be, the ListDatabases` property needs to exclude system database, read only databases and unavailable databases. [] should be added in multiple other places to avoid potential errors.

I've already made these changes and I'll raise a PR for these later on.

RachelAmbler pushed a commit to RachelAmbler/eGrate that referenced this issue Sep 12, 2022
@erikbra
Copy link
Owner

erikbra commented Apr 18, 2024

Mostly solved by #501 - please open another issue if you see anything else that should be changed. It's way easier to update the grate structure after #482 :)

@erikbra erikbra closed this as completed Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants