Merge pull request #1 from erikaheidi/improve-test-coverage

adding more tests and updating dependencies

composer.json

@@ -10,6 +10,7 @@
         }
     },
     "require": {
+        "php": "^8.2.0",
         "minicli/minicli": "^4.2",
         "minicli/stencil": "^0.2.1"
     },

src/DataFeed/JsonDataFeed.php

@@ -2,6 +2,7 @@
 
 namespace Autodocs\DataFeed;
 
+use Autodocs\Exception\JsonException;
 use Autodocs\Exception\NotFoundException;
 
 class JsonDataFeed implements DataFeedInterface
@@ -19,9 +20,18 @@ public function loadFile(string $file): void
         }
 
         $this->data = file_get_contents($file);
-        if ($this->data) {
-            $this->json = json_decode($this->data, true);
+
+        if (!$this->data) {
+            throw new JsonException("JSON file is empty.");
+        }
+
+        $json = json_decode($this->data, true);
+        if (!is_array($json)) {
+            throw new JsonException("Unable to decode JSON file.");
         }
+
+        $this->json = $json;
+
     }
 
     public function load(string $data): void

src/Exception/JsonException.php

@@ -0,0 +1,8 @@
+<?php
+
+namespace Autodocs\Exception;
+
+class JsonException extends \Exception
+{
+
+}

tests/Resources/broken-json.json

@@ -0,0 +1,3 @@
+{
+  "something":
+}

tests/Unit/DataFeedTest.php

@@ -9,3 +9,17 @@
 
     $this->assertNotEmpty($datafeed->json);
 });
+
+it('throws JSON exception with a broken JSON', function () {
+
+    $datafeed = new JsonDataFeed('test');
+    $datafeed->loadFile(__DIR__ . '/../Resources/broken-json.json');
+
+})->throws(\Autodocs\Exception\JsonException::class);
+
+it('throws JSON Exception with an empty JSON', function () {
+
+    $datafeed = new JsonDataFeed('test');
+    $datafeed->loadFile(__DIR__ . '/../Resources/empty-json.json');
+
+})->throws(\Autodocs\Exception\JsonException::class);