Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: [EIP-4844] Point evaluation precompile #945

Merged
merged 22 commits into from
Apr 6, 2023
Merged

Conversation

yperbasis
Copy link
Member

@yperbasis yperbasis commented Mar 31, 2023

This PR only adds the precompile, not the entire EIP-4844. Implementation is based on c-kzg-4844.

@yperbasis yperbasis added the cancun The Cancun protocol upgrade label Mar 31, 2023
@yperbasis yperbasis changed the title [EIP-4844] Point evaluation precompile core: [EIP-4844] Point evaluation precompile Apr 4, 2023
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #945 (9542f52) into master (3a695b9) will increase coverage by 0.06%.
The diff coverage is 86.25%.

@@            Coverage Diff             @@
##           master     #945      +/-   ##
==========================================
+ Coverage   68.12%   68.18%   +0.06%     
==========================================
  Files         218      219       +1     
  Lines       17425    17534     +109     
  Branches     2697     2706       +9     
==========================================
+ Hits        11870    11955      +85     
- Misses       4492     4509      +17     
- Partials     1063     1070       +7     
Impacted Files Coverage Δ
silkworm/core/execution/evm.hpp 80.00% <ø> (ø)
silkworm/core/crypto/kzg.cpp 83.14% <83.14%> (ø)
silkworm/core/execution/precompile.cpp 96.47% <91.17%> (-0.54%) ⬇️
silkworm/core/common/base.hpp 100.00% <100.00%> (ø)
silkworm/core/execution/evm.cpp 93.75% <100.00%> (-0.24%) ⬇️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yperbasis yperbasis marked this pull request as ready for review April 4, 2023 14:44
@canepat canepat merged commit 3ad85ef into master Apr 6, 2023
@canepat canepat deleted the point_eval_precompile branch April 6, 2023 07:51
@yperbasis yperbasis mentioned this pull request Jun 1, 2023
@yperbasis yperbasis mentioned this pull request Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cancun The Cancun protocol upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants