datastore: fix debug_getModifiedAccountsBy regression #2771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
battlmonstr
commented
Mar 5, 2025
battlmonstr
commented
- owning_view: support SegmentReader (make it movable)
- caching_view: move instead of assigning to support more cases
- merge_many: hold produced ranges, not only their iterators
battlmonstr
force-pushed
the
pr/hist_as_of
branch
2 times, most recently
from
184a1f0 to
a9bd934
Compare
* owning_view: support SegmentReader (make it movable) * caching_view: move instead of assigning to support more cases * merge_many: hold produced ranges, not only their iterators
canepat
added
the
maintenance
canepat
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.