db: rename kv Query to Request #2768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
battlmonstr
force-pushed
the
pr/hist_as_of
branch
3 times, most recently
from
184a1f0 to
a9bd934
Compare
JacekGlen
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
That looks good.
I just have one thought: can we apply similar logic to silkworm::datastore::kvdb:: and silkworm::db::state::?
Or maybe use a different approach and apply the following naming convention:
- DomainGetLatestQuery -> DomainGetLatestQuery
- DomainPutQuery -> DomainPutCommand
- DomainDeleteQuery -> DomainDeleteCommand
I know it's a minor thing but things like DomainPutQuery might be confusing
| @@ -1050,14 +1050,14 @@ int kv_get_latest() { | |||
| const auto verbose{absl::GetFlag(FLAGS_verbose)}; | |||
|
|
|||
| if (timestamp > -1) { | |||
| GetAsOfQuery query{ | |||
| GetAsOfRequest query{ | |||
There was a problem hiding this comment.
Suggested change
| GetAsOfRequest query{ | |
| GetAsOfRequest request{ |
| .table = table_name, | ||
| .key = *key_bytes, | ||
| .timestamp = timestamp, | ||
| }; | ||
| return execute_temporal_kv_query(target, kv_get_as_of_query, std::move(query), verbose); | ||
| } | ||
| GetLatestQuery query{ | ||
| GetLatestRequest query{ |
There was a problem hiding this comment.
Suggested change
| GetLatestRequest query{ | |
| GetLatestRequest request{ |
|
@JacekGlen thanks for the review, let's discuss it further live. I'll address the found leftovers in a follow up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.