rpcdaemon: gas cost from EVMONE for debug family API #2325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sixtysixter
force-pushed
the
feature/gas_cost_from_evmone
branch
from
ec87872 to
fab16dc
Compare
canepat
added
the
maintenance
canepat
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Even if the code is not clean enough yet, I'm really keen on merging this PR because it introduces the improved evmone tracing API.
@Sixtysixter as discussed, you will do a follow-up PR to clean up the code
canepat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant changes: