Use the same block executor for both CAPI and StagedSync #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canepat
changed the title
canepat
added
the
maintenance
canepat
requested changes
Sep 10, 2024
| using namespace std::chrono_literals; | ||
|
|
||
| //! Generate log arguments for execution progress at specified block | ||
| static log::Args log_args_for_exec_progress(BlockExecutor::ExecutionProgress& progress, uint64_t current_block) { |
There was a problem hiding this comment.
This logging format is specifically crafted for Erigon++ to match Erigon logs and must be kept into the C API implementation. The stage pipeline has its own timer-based logging mechanism that must remain the same because it's shared among all the stages.
| log::Info{"[4/12 Execution] Executed blocks", // NOLINT(*-unused-raii) | ||
| log_args_for_exec_progress(progress_, block.header.number)}; | ||
| log_time_ = now + 20s; | ||
| } |
There was a problem hiding this comment.
This logging format is specifically crafted for Erigon++ to match Erigon logs and must be kept into the C API implementation. The stage pipeline has its own timer-based logging mechanism that must remain the same because it's shared among all the stages.
…rigontech/silkworm into 2078-execution-improve-stage-execution
canepat
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.