Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sentry: handle errors when accessing socket endpoints #2306

Merged
merged 1 commit into from
Sep 6, 2024
Merged

sentry: handle errors when accessing socket endpoints #2306

merged 1 commit into from
Sep 6, 2024

Conversation

canepat
Copy link
Member

@canepat canepat commented Sep 5, 2024

Fixes #2300

@canepat canepat added the maintenance Some maintenance work (fix, refactor, rename, test...) label Sep 5, 2024
@canepat canepat requested a review from battlmonstr September 5, 2024 10:35
@canepat canepat marked this pull request as ready for review September 5, 2024 11:30
battlmonstr
battlmonstr approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@battlmonstr battlmonstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect! ✨

@battlmonstr battlmonstr merged commit 1f12a80 into master Sep 6, 2024
5 checks passed
@battlmonstr battlmonstr deleted the sentry_fix_unexpected_termination_issue_2300 branch September 6, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@battlmonstr battlmonstr battlmonstr approved these changes

Assignees
No one assigned
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

silkworm: unexpected Sentry termination after peer disconnection
2 participants
@canepat @battlmonstr