third-party: update erigon-snapshot to da5d0f5 #2265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canepat
changed the title
canepat
added
the
maintenance
canepat
approved these changes
Aug 26, 2024
| @@ -60,4 +63,16 @@ BlockNum Config::compute_max_block() { | |||
| return max_block > 0 ? max_block - 1 : 0; | |||
| } | |||
|
|
|||
| void Config::remove_unsupported_snapshots() { | |||
| constexpr std::array UNSUPPORTED_SNAPSHOT_NAME_TOKENS = { | |||
There was a problem hiding this comment.
In terms of code style we follow Google C++ Style Guidelines, where the naming convention for constants is this. Hence, this one should read:
kUnsupportedSnapshotNameTokens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the list of updated snapshots for mainnet, bor and sepolia. In addition there's an extra function that filters out unsupported snapshot files (introduced in erigon 3). One of the tests has been simplified since the ranges have changed at some point (from 500k to 100k) and later down to even 10k (hence computing snapshots count have become unreliable).