rpcdaemon: add STOP opcode as last opcode in specific success cases #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canepat
added
the
maintenance
canepat
changed the title
canepat
approved these changes
Aug 26, 2024
| @@ -778,6 +780,23 @@ void VmTraceTracer::on_execution_end(const evmc_result& result, const silkworm:: | |||
| } | |||
| break; | |||
| } | |||
|
|
|||
| /* EVM WA: EVMONE add OP_STOP at the end of tx if not present but doesn't notify to the tracer. Add sw to add STOP to the op list */ | |||
| if (result.status_code == EVMC_SUCCESS && last_opcode_ && last_opcode_ != OP_SELFDESTRUCT && last_opcode_ != OP_RETURN && last_opcode_ != OP_STOP) { | |||
There was a problem hiding this comment.
I suggest extracting this condition in a dedicated function not to repeat it twice. Next PR is fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synthesise OP_STOP as last opcode in
traceanddebugAPI if execution is successful and last opcode executed is NOT in [OP_SELFDESTRUCT, OP_RETURN, OP_STOP]