rpcdaemon: fix debug/trace API family gas cost step 2 #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sixtysixter
force-pushed
the
fix/debug_trace_api_family_gas_cost_2
branch
from
e68c161 to
3077a58
Compare
Sixtysixter
force-pushed
the
fix/debug_trace_api_family_gas_cost_2
branch
from
c81d85a to
fee1778
Compare
canepat
added
the
maintenance
canepat
approved these changes
Jul 18, 2024
| @@ -75,6 +75,7 @@ struct CallFixes { | |||
| int64_t stipend{0}; | |||
| int16_t code_cost{0}; | |||
| int64_t gas_cost{0}; | |||
| bool precompiled{false}; | |||
| }; | |||
There was a problem hiding this comment.
CallFixes is a little bit weird, I suggest renaming it as CallGasRepair. Also, repair_call_gas_accounting is probably better than evaluate_call_fixes.
You can do it in next PR
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for gas cost in debug_trace API family