Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpcdaemon: remove optional in read chain config #2130

Merged
merged 4 commits into from
Jun 20, 2024
Merged

rpcdaemon: remove optional in read chain config #2130

merged 4 commits into from
Jun 20, 2024

Conversation

canepat
Copy link
Member

@canepat canepat commented Jun 20, 2024

This PR removes std::optional from the returned type of ChainStorage::read_chain_config and raises an exception in case of missing chain configuration.

Fixes #2103

Extras

  • change the type of exception raised by read_head_header_hash
  • pass into::uint256 by reference in to_quantity

@canepat canepat added the maintenance Some maintenance work (fix, refactor, rename, test...) label Jun 20, 2024
@canepat canepat requested a review from lupin012 June 20, 2024 11:28
@canepat canepat marked this pull request as ready for review June 20, 2024 12:45
@canepat canepat merged commit b0bc318 into master Jun 20, 2024
4 checks passed
@canepat canepat deleted the rpcdaemon_read_chain_config_no_optional branch June 20, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lupin012 lupin012 lupin012 approved these changes

Assignees
No one assigned
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rpcdaemon: ChainStorage hierarchy should use just one error mechanism
2 participants
@canepat @lupin012