rpcdaemon: refactoring ContextTestBase as infra test utility #2127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits
rpc::test:: ContextTestBase
into two different test utility abstractions:silkworm::test_util:: ContextTestBase
ininfra
modulesilkworm::rpc::test_util::ServiceContextTestBase
inrpc
modulein order to remove any dependency of
rpc/storage
package fromrpc/test_util
, as a preparation step to then movestorage
package indb
module.After this PR, the only remaining
rpc/storage
dependencies inrpc
are fromether::kv::Transaction
andrpc::test::MockTransaction
, which will be moved together withstorage
.Extras
kEarliestBlockNumber
definition fromrpc
tocore
to break dependency ofrpc/storage
package fromrpc/core
test
astest_util
for naming consistency