Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcdaemon: update ignore list and add subtest ignore list in I/O tests #2093

Merged
merged 2 commits into from
Jun 12, 2024
Merged

rpcdaemon: update ignore list and add subtest ignore list in I/O tests #2093

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
403792d
update ignore api list and add subtest ignore list
lupin012 Jun 11, 2024
4d9d6b2
make fmt
web-flow Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions silkworm/rpc/commands/rpc_api_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,15 @@ bool are_equivalent(const nlohmann::json& obj1, const nlohmann::json& obj2) {
}

static const std::vector<std::string> tests_to_ignore = {
"eth_estimateGas", // call to oracle fails, needs fixing
"debug_getRawReceipts", // not implemented
"eth_getProof", // not implemented
"eth_feeHistory", // history not stored, needs fixing
"eth_sendRawTransaction", // call to oracle fails, needs fixing or mocking
"eth_createAccessList", // expected value doesn't contain gas optimization
"debug_getRawReceipts", // not implemented
"eth_sendRawTransaction", // call to txpool fails, needs mocking
};

static const std::vector<std::string> subtests_to_ignore = {
"create-al-multiple-reads.io", // eth_createAccessList: expected value doesn't contain gas optimization
"estimate-simple-transfer.io", // eth_estimateGas doesn't expect baseFeeGas without GasPrice
"estimate-simple-contract.io", // eth_estimateGas doesn't expect baseFeeGas without GasPrice
};

// Exclude tests from sanitizer builds due to ASAN/TSAN warnings inside gRPC library
Expand All @@ -87,6 +90,10 @@ TEST_CASE("rpc_api io (all files)", "[rpc][rpc_api]") {
continue;
}

if (std::find(subtests_to_ignore.begin(), subtests_to_ignore.end(), test_name) != subtests_to_ignore.end()) {
continue;
}

std::ifstream test_stream(test_file.path());

if (!test_stream.is_open()) {
Expand Down
Loading