rpcdaemon: add blob check on evm executor

.github/workflows/rpc-integration-tests.yml

@@ -27,7 +27,7 @@ jobs:
       - name: Checkout RPC Tests Repository & Install Requirements
         run: |
           rm -rf ${{runner.workspace}}/rpc-tests
-          git -c advice.detachedHead=false clone --depth 1 --branch v0.12.0 https://github.com/erigontech/rpc-tests ${{runner.workspace}}/rpc-tests
+          git -c advice.detachedHead=false clone --depth 1 --branch v0.16.0 https://github.com/erigontech/rpc-tests ${{runner.workspace}}/rpc-tests
           cd ${{runner.workspace}}/rpc-tests
           pip3 install -r requirements.txt
 

silkworm/rpc/core/evm_executor.cpp

@@ -203,6 +203,23 @@ std::optional<EVMExecutor::PreCheckResult> EVMExecutor::pre_check(const EVM& evm
             }
         }
     }
+
+    if (evm.block().header.blob_gas_used && rev >= EVMC_CANCUN) {
+        if (evm.block().header.excess_blob_gas) {
+            std::string error = "internal Error Cancun is active but ExcessBlobGas is nil";
+            return PreCheckResult{error, PreCheckErrorCode::kInternalError};
+        }
+        auto blob_gas_price = evm.block().header.blob_gas_price();
+        auto max_fee_per_blob_gas = txn.max_fee_per_blob_gas;
+        if (blob_gas_price > max_fee_per_blob_gas) {
+            std::string from = address_to_hex(*txn.sender());
+            std::string error = "max fee per blob gas too low: address " + from + ", maxFeePerBlobGas: " + intx::to_string(max_fee_per_blob_gas) +
+                                " blobGasPrice: " + intx::to_string(*blob_gas_price) +
+                                ", excessBlobGas: " + std::to_string(*evm.block().header.excess_blob_gas);
+            return PreCheckResult{error, PreCheckErrorCode::kMaxFeePerBlobGasTooLowError};
+        }
+    }
+
     if (txn.gas_limit < g0) {
         std::string from = address_to_hex(*txn.sender());
         std::string error = "intrinsic gas too low: address " + from + ", have " + std::to_string(txn.gas_limit) + ", want " + intx::to_string(g0);
@@ -246,6 +263,7 @@ ExecutionResult EVMExecutor::call(
         return {std::nullopt, txn.gas_limit, data, pre_check_result->pre_check_error, pre_check_result->pre_check_error_code};
     }
 
+    // EIP-1559 normal gas cost
     intx::uint256 want;
     if (txn.max_fee_per_gas > 0 || txn.max_priority_fee_per_gas > 0) {
         // This method should be called after check (max_fee and base_fee) present in pre_check() method
@@ -254,6 +272,14 @@ ExecutionResult EVMExecutor::call(
     } else {
         want = 0;
     }
+
+    // EIP-4844 blob gas cost (calc_data_fee)
+    if (evm.block().header.blob_gas_used && rev >= EVMC_CANCUN) {
+        // compute blob fee for eip-4844 data blobs if any
+        const intx::uint256 blob_gas_price{evm.block().header.blob_gas_price().value_or(0)};
+        want += txn.total_blob_gas() * blob_gas_price;
+    }
+
     const auto have = ibs_state_.get_balance(*txn.sender());
     if (have < want + txn.value) {
         if (!gas_bailout) {

silkworm/rpc/core/evm_executor.hpp

@@ -42,9 +42,11 @@
 namespace silkworm::rpc {
 
 enum PreCheckErrorCode {
-    kIntrinsicGasTooLow,
-    kInsufficientFunds,
     kFeeCapLessThanBlockFeePerGas,
+    kInsufficientFunds,
+    kInternalError,
+    kIntrinsicGasTooLow,
+    kMaxFeePerBlobGasTooLowError,
     kTipHigherThanFeeCap
 };