Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpcdaemon: improve JWT handling in HTTP connection #1982

Merged
merged 4 commits into from
Apr 25, 2024
Merged

rpcdaemon: improve JWT handling in HTTP connection #1982

merged 4 commits into from
Apr 25, 2024

Conversation

canepat
Copy link
Member

@canepat canepat commented Apr 23, 2024

This PR refines the JSON Web token (JWT) support in HTTP connection by:

  • adding unit tests
  • implementing the optional check for issued-at claim as specified in Execution APIs
  • fixing exception handling
  • improving code readability (naming, comments)

Extras

Remove unused HTTP constant.

@canepat canepat added the maintenance Some maintenance work (fix, refactor, rename, test...) label Apr 23, 2024
@canepat canepat requested review from Sixtysixter and lupin012 April 23, 2024 06:04
@canepat canepat merged commit 4c21489 into master Apr 25, 2024
4 checks passed
@canepat canepat deleted the rpcdaemon_http_improve_jwt_handling branch April 25, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lupin012 lupin012 lupin012 approved these changes

@Sixtysixter Sixtysixter Awaiting requested review from Sixtysixter

Assignees
No one assigned
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@canepat @lupin012 @web-flow