-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
capi: export RpcDaemon configuration settings #1968
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpcdaemon: extract and reuse some default values
canepat
added
enhancement
New feature or improvement
c api
The C API exposed for Erigon
labels
Apr 15, 2024
JacekGlen
reviewed
Apr 16, 2024
capi: make SilkwormLogLevel enum anonymous
capi: unit tests for RpcDaemon start/stop
extend unit tests
JacekGlen
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exports our Silkworm RPC Daemon configuration settings in the C API interface. The following options can be customised (all of them are opt-in, default values provide a meaningful configuration):
Extras
This PR also adds the logging verbosity level as Silkworm instance global setting. This is necessary to make Silkworm emit logs with the same verbosity as the C API client code, if needed.