Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: macOS job - use Xcode 15 #1929

Merged
merged 3 commits into from
Mar 22, 2024
Merged

ci: macOS job - use Xcode 15 #1929

merged 3 commits into from
Mar 22, 2024

Conversation

battlmonstr
Copy link
Contributor

No description provided.

@battlmonstr battlmonstr marked this pull request as ready for review March 21, 2024 16:28
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.15%. Comparing base (3d35188) to head (f9e12de).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1929      +/-   ##
==========================================
- Coverage   53.16%   53.15%   -0.01%     
==========================================
  Files         610      610              
  Lines       45725    45725              
  Branches     7038     7038              
==========================================
- Hits        24310    24307       -3     
- Misses      19298    19300       +2     
- Partials     2117     2118       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@canepat canepat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK for me to bump the Xcode version in CI job, but I would pair this change with a proper fix for the build regression introduced by #1926 surrounding add_link_options with a check on compiler version:

  if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 15)
    # https://stackoverflow.com/questions/77164140/
    add_link_options(-Wl,-no_warn_duplicate_libraries)
  endif()

@battlmonstr
Copy link
Contributor Author

@canepat 👌 implemented here: #1928

It's OK for me to bump the Xcode version in CI job, but I would pair this change with a proper fix for the build regression introduced by #1926 surrounding add_link_options with a check on compiler version:

  if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 15)
    # https://stackoverflow.com/questions/77164140/
    add_link_options(-Wl,-no_warn_duplicate_libraries)
  endif()

@battlmonstr battlmonstr requested a review from canepat March 22, 2024 09:41
@canepat canepat merged commit 91605a3 into master Mar 22, 2024
16 checks passed
@canepat canepat deleted the ci/mac_bug branch March 22, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants