Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcdaemon: simplify HTTP gzip compression handling #1923

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

canepat
Copy link
Member

@canepat canepat commented Mar 19, 2024

rpcdaemon: fix Clang Tidy after PR 1914

@canepat canepat added the maintenance Some maintenance work (fix, refactor, rename, test...) label Mar 19, 2024
@canepat canepat requested a review from lupin012 March 19, 2024 16:28
silkworm/rpc/http/connection.cpp Outdated Show resolved Hide resolved
silkworm/rpc/http/connection.cpp Show resolved Hide resolved
silkworm/rpc/http/connection.cpp Outdated Show resolved Hide resolved
@canepat canepat requested a review from lupin012 March 19, 2024 19:02
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 52.82%. Comparing base (2f34e83) to head (e4cca04).

Files Patch % Lines
silkworm/rpc/http/connection.cpp 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1923      +/-   ##
==========================================
- Coverage   53.10%   52.82%   -0.29%     
==========================================
  Files         610      610              
  Lines       45750    45729      -21     
  Branches     7042     7038       -4     
==========================================
- Hits        24296    24156     -140     
- Misses      19335    19451     +116     
- Partials     2119     2122       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@canepat canepat merged commit 86a166b into master Mar 19, 2024
14 of 15 checks passed
@canepat canepat deleted the ci/rpc_simplify_gzip_handling_fix_tidy branch March 19, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants